Skip to content

Fix playing of Spotify URIs on Sonos#43154

Merged
balloob merged 1 commit intohome-assistant:devfrom
amelchio:pysonos-0_0_36
Nov 13, 2020
Merged

Fix playing of Spotify URIs on Sonos#43154
balloob merged 1 commit intohome-assistant:devfrom
amelchio:pysonos-0_0_36

Conversation

@amelchio
Copy link
Copy Markdown
Contributor

Proposed change

This change makes Spotify URIs work with more Sonos configurations.

Changelog: https://github.com/amelchio/pysonos/releases/tag/v0.0.36

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@amelchio amelchio added this to the 0.118.0 milestone Nov 12, 2020
@probot-home-assistant probot-home-assistant Bot added dependency-bump Pull requests that update a dependency file bugfix integration: sonos small-pr PRs with less than 30 lines. labels Nov 12, 2020
@amelchio amelchio changed the title Fix playing of Spotify URIs Fix playing of Spotify URIs on Sonos Nov 12, 2020
@balloob balloob merged commit 96641ca into home-assistant:dev Nov 13, 2020
balloob pushed a commit that referenced this pull request Nov 13, 2020
KJonline pushed a commit to Pyhass/core that referenced this pull request Nov 13, 2020
* 'dev' of https://github.com/home-assistant/core: (32 commits)
  Disable parsing scientific/complex number notation in template type (home-assistant#43170)
  Remove relative time sensor from cert_expiry (home-assistant#42338)
  Further improve MFI tests (home-assistant#43167)
  Update translations
  Guard against empty ssdp locations (home-assistant#43156)
  Fix playing of Spotify URIs on Sonos (home-assistant#43154)
  Add missing 'hassio' translation string (home-assistant#43127)
  Streamline SimpliSafe errors (home-assistant#43117)
  Update xknx to 0.15.3 (home-assistant#42026)
  Fix beat calculation (home-assistant#43142)
  Mock time_date sensor tests (home-assistant#43141)
  [ci skip] Translation update
  Fix bug preventing Notion entities from updating their bridge (home-assistant#43122)
  Bump hass-nabucasa to 0.37.2 (home-assistant#43146)
  Shelly: minor improvements (home-assistant#43138)
  Add support for learning RF commands with Broadlink remotes (home-assistant#39671)
  Fix incorrect Notion battery state calculation (home-assistant#43108)
  Bump hatasmota to 0.0.30 (home-assistant#43140)
  Add VSCode debug launch conf (home-assistant#43130)
  Revert "shelly_naming" rebase errors (home-assistant#43134)
  ...
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed dependency-bump Pull requests that update a dependency file integration: sonos small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playing Spotify URIs with the Sonos integration fails with UPnP Error 800

4 participants